Bug 60292 – [chromium] Rebaseline needed for video-source-error

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Steve Lacey]

As chromium doesn't support mp4, we need to expect an error from 'supported-format-mp4'. I thought about changing the name of this tag to 'maybe-supported-format-mp4', but the churn in expectations didn't seem worth it.

[Steve Lacey]

Created attachment 92448 [details]
Patch

[Eric Carlson]

Comment on attachment 92448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92448&action=review

> LayoutTests/ChangeLog:12
> +        * platform/chromium-mac/media/video-source-error-expected.txt: Added.
> +        * platform/chromium-win/media/video-source-error-expected.txt: Added.

These two results files are identical, are you linux results also the same? If so, a single file would be better.

[Steve Lacey]

Created attachment 92459 [details]
Patch

[Steve Lacey]

Comment on attachment 92448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92448&action=review

>> LayoutTests/ChangeLog:12
>> +        * platform/chromium-win/media/video-source-error-expected.txt: Added.
> 
> These two results files are identical, are you linux results also the same? If so, a single file would be better.

Indeed they are identical. chromium-linux falls back to chromium-win, so all three are identical and I've moved it into platform/chromium.

Looks like I need to go do some more work in the rebaselining tool...

[WebKit Commit Bot]

Comment on attachment 92459 [details]
Patch

Rejecting attachment 92459 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
 from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/media/video-source-error-expected.txt
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 819.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8590030

[Steve Lacey]

Created attachment 92483 [details]
Patch

[Steve Lacey]

Fixed conflict.

[Steve Lacey]

Could someone flip the bits before test_expectations changes too much again :-)

Thx.

[WebKit Commit Bot]

Comment on attachment 92483 [details]
Patch

Clearing flags on attachment: 92483

Committed r85965: <http://trac.webkit.org/changeset/85965>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 92483 [details]:

http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: [e-mail])
The commit-queue is continuing to process your patch.

[Eric Seidel (no email)]

Comment on attachment 92448 [details]
Patch

Cleared review? from obsolete attachment 92448 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).