Bug 60286

Summary: Web Inspector: [Chromium] Enable detailed heap snapshots by default
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
pfeldman: review-, mnaganov: commit-queue-
comments addressed pfeldman: review+, mnaganov: commit-queue-

Description Mikhail Naganov 2011-05-05 12:09:30 PDT 
I'm currently leaving out the old panel code to be able to quickly switch back in case if something goes wrong. I'll remove old code later.
Comment 1 Mikhail Naganov 2011-05-05 12:18:10 PDT 
Created attachment 92443 [details]
patch
Comment 2 Pavel Feldman 2011-05-05 14:15:48 PDT 
Comment on attachment 92443 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92443&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:741
>              var combo = ["U+004C", "U+0045", "U+0041", "U+004B", "U+005A"];  // "LEAKZ"

Is there a reason you would like to keep this code around?
Comment 3 Mikhail Naganov 2011-05-06 11:15:00 PDT 
Created attachment 92610 [details]
comments addressed
Comment 4 Mikhail Naganov 2011-05-18 02:48:00 PDT 
Manually committed http://trac.webkit.org/changeset/86746

2011-05-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
        https://bugs.webkit.org/show_bug.cgi?id=60286

        * inspector/front-end/ProfilesPanel.js:

2011-05-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
        https://bugs.webkit.org/show_bug.cgi?id=60286

        * src/js/DevTools.js:
        ():