Bug 60263

Summary:

Web Inspector: fix source mapping for formatted scripts.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch.	yurys: review+

Pavel Podivilov

Reported 2011-05-05 05:08:33 PDT

Web Inspector: fix source mapping for formatted scripts. Source mapping is broken for script chunks that are already formatted at the beginning and at the end of the script.

Attachments
Patch. (13.49 KB, patch) 2011-05-05 05:09 PDT, Pavel Podivilov	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-05-05 05:09:29 PDT

Created attachment 92404 [details] Patch.

Yury Semikhatsky

Comment 2 2011-05-13 04:40:58 PDT

Comment on attachment 92404 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=92404&action=review > LayoutTests/inspector/debugger/script-formatter.html:69 > + testMapping("function"); Can we just dump formatted source to see the correct result?

Pavel Podivilov

Comment 3 2011-05-13 10:24:46 PDT

(In reply to comment #2) > (From update of attachment 92404 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92404&action=review > > > LayoutTests/inspector/debugger/script-formatter.html:69 > > + testMapping("function"); > > Can we just dump formatted source to see the correct result? This is a test for source mapping. How would dumping formatted source help us to test the mapping?

Pavel Podivilov

Comment 4 2011-05-13 10:27:41 PDT

Committed r86443: <http://trac.webkit.org/changeset/86443>

Note You need to log in before you can comment on or make changes to this bug.