Bug 60262 – Eliminate WebCore/dom/InputElement.{cpp,h}

• Component: DOM
• Status: RESOLVED FIXED

[Kent Tamura]

InputElement is not needed anymore because WML was removed.

[Kent Tamura]

Created attachment 92403 [details]
Try

[WebKit Review Bot]

Attachment 92403 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/html/HTMLInputElement.cpp:1021:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 92403 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8551863

[Build Bot]

Attachment 92403 [details] did not build on win:
Build output: http://queues.webkit.org/results/8554884

[Kent Tamura]

Created attachment 92412 [details]
Try 2

[Dimitri Glazkov (Google)]

This looks awesome! Yay! Can't wait to see the patch that's ready for review.

[Collabora GTK+ EWS bot]

Attachment 92412 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8571466

[Alexey Proskuryakov]

Awesome!

[Kent Tamura]

Created attachment 92460 [details]
Patch

[Kent Tamura]

Created attachment 92476 [details]
Patch 2

Rebase

[Kent Tamura]

Created attachment 92538 [details]
Patch 3

GTK build fix

[Ryosuke Niwa]

Comment on attachment 92538 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=92538&action=review

> Source/WebCore/html/HTMLInputElement.cpp:518
> +        m_value =  sanitizeValue(fastGetAttribute(valueAttr));

Nit: Two spaces after =.

> Source/WebCore/html/HTMLInputElement.cpp:649
> +        int maxLength = attr->isNull() ? maximumLength : attr->value().toInt();
> +        if (maxLength <= 0 || maxLength > maximumLength)
> +            maxLength = maximumLength;
> +        int oldMaxLength = m_maxLength;
> +        m_maxLength = maxLength;
> +        if (oldMaxLength != maxLength)
> +            updateValueIfNeeded();

I would have preferred to keep this in a helper function.

> Source/WebCore/html/HTMLInputElement.cpp:655
> +        if (renderer())
> +            renderer()->setNeedsLayoutAndPrefWidthsRecalc();

Maybe we need to call setNeedsStyleRecalc here as well because we could have a style rule that matches size attribute such as input[size=5]. Of course, that would be a separate patch.

> Source/WebCore/html/HTMLInputElement.cpp:1519
> +static inline const AtomicString& formatCodes()
> +{
> +    DEFINE_STATIC_LOCAL(AtomicString, codes, ("AaNnXxMm"));
> +    return codes;
> +}

This entire section needs to be cleaned up at some point :(

[Kent Tamura]

Comment on attachment 92538 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=92538&action=review

>> Source/WebCore/html/HTMLInputElement.cpp:518
>> +        m_value =  sanitizeValue(fastGetAttribute(valueAttr));
> 
> Nit: Two spaces after =.

Fixed.

>> Source/WebCore/html/HTMLInputElement.cpp:649
>> +            updateValueIfNeeded();
> 
> I would have preferred to keep this in a helper function.

ok, I revived parseMaxLengthAttribute().

[Kent Tamura]

Created attachment 92678 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 92678 [details]
Patch for landing

Clearing flags on attachment: 92678

Committed r85998: <http://trac.webkit.org/changeset/85998>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.