Bug 60257

Summary: build-webkit --minimal build is broken because of r84789
Product: WebKit Reporter: Bharathwaaj <bharathwaaj.s>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, webkit.review.bot, xan.lopez, zecke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch addressing only the issue
none
Fix minimal build none

Description Bharathwaaj 2011-05-05 01:29:12 PDT 
Compilation error when building with the following command.

Tools/Scripts/build-webkit --gtk --no-svg --no-svg-animation --no-svg-as-image --no-svg-dom-objc-bindings --no-svg-fonts --no-svg-foreign-object --no-svg-use --disable-optimizations
Comment 1 Bharathwaaj 2011-05-05 02:11:55 PDT 
Created attachment 92392 [details]
Patch

Gaurd with appropriate enable macros.
Comment 2 WebKit Review Bot 2011-05-05 02:14:39 PDT 
Attachment 92392 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Bharathwaaj 2011-05-05 02:18:17 PDT 
Created attachment 92394 [details]
Patch

Removed tabs.
Comment 4 Bharathwaaj 2011-05-05 03:30:40 PDT 
Created attachment 92400 [details]
Patch addressing only the issue

This patch removes the reindentation done in previous patches as reviewed by zecke in irc.
Comment 5 Bharathwaaj 2011-05-05 06:41:51 PDT 
Created attachment 92409 [details]
Fix minimal build

Addressed review comments provided by zecke in irc.
Comment 6 Holger Freyther 2011-05-05 06:47:03 PDT 
Comment on attachment 92409 [details]
Fix minimal build

This appears to be the minimal fix for --minimal. With BLOB/FILESYSTEM there is already the case for having #if ENABLE() guards for the JS exceptions.
Comment 7 WebKit Commit Bot 2011-05-05 12:20:31 PDT 
The commit-queue encountered the following flaky tests while processing attachment 92409 [details]:

java/lc3/JSNumber/ToChar-002-n.html bug 60288 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2011-05-05 12:21:49 PDT 
Comment on attachment 92409 [details]
Fix minimal build

Clearing flags on attachment: 92409

Committed r85868: <http://trac.webkit.org/changeset/85868>
Comment 9 WebKit Commit Bot 2011-05-05 12:21:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Ademar Reis 2011-05-10 13:33:09 PDT 
Revision r85868 cherry-picked into qtwebkit-2.2 with commit 093ccfe <http://gitorious.org/webkit/qtwebkit/commit/093ccfe>