Bug 6025

Summary: CDF example renders SVG on top of text
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Simple cdf example
none
proposed patch darin: review+

Eric Seidel (no email)
Reported 2005-12-09 14:23:19 PST
CDF example renders SVG on top of text See attached test case (already landed under LayoutTests/svg/custom/simpleCDF.xml).
Attachments
Simple cdf example (393 bytes, application/xml)
2005-12-09 14:24 PST, Eric Seidel (no email) 		no flags
Details
proposed patch (1.44 KB, patch)
2006-01-28 04:50 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-12-09 14:24:04 PST
Created attachment 5013 [details] Simple cdf example
Dave Hyatt
Comment 2 2005-12-09 14:25:25 PST
My guess would be that you need to implement baselinePosition and lineHeight on <svg> as is done with images.
Eric Seidel (no email)
Comment 3 2005-12-13 03:45:19 PST
Yes, hyatt's suggestion does fix the bug. However, now I'm seeing my svgs being translated manually using m_x and m_y in the svg error cases (where <svg> is embedded inside a <body> element right after some <h3> and <p> text elements). Those are causing me to hit asserts... which I'm not quite sure what to do with yet.
Eric Seidel (no email)
Comment 4 2006-01-26 15:48:22 PST
This is our most basic CDF issue. This is also one which is very well understood and shoudn't take very long to solve. We would not want to ship WebKit SVG support w/o this CDF issue solved. Bumping to p2, and adding SVGHitList keyword.
Eric Seidel (no email)
Comment 5 2006-01-28 04:50:22 PST
Created attachment 6044 [details] proposed patch Simple fix.
Darin Adler
Comment 6 2006-01-28 16:49:55 PST
Comment on attachment 6044 [details] proposed patch Generally we put spaces around "=" as in: isRootLineBox=false I'd rather see C++ casts, like static_cast, then C-style casts in this code. Since virtual function calls are never inlined, it's usually best to put the implementations of virtual functions in a .cpp file rather than a header. Is there a test that goes with this? r=me
Eric Seidel (no email)
Comment 7 2006-01-28 17:17:20 PST
Fixed. This is already covered by svg/custom/simpleCDF.xml
Eric Seidel (no email)
Comment 8 2006-01-29 06:40:37 PST
Fixed in r12454.
Note You need to log in before you can comment on or make changes to this bug.