Bug 60232 – Associate <keygen> request with Frame.

• Component: Platform
• Status: RESOLVED WONTFIX

[Matt Mueller]

In Chromium Linux we have to be able to show a dialog to unlock crypto devices when doing a keygen.  We'd like this to be a tab-constrained dialog instead of a regular one.  This change allows associating a specific keygen request with the tab that caused it.

[Matt Mueller]

Created attachment 92350 [details]
patch

[Matt Mueller]

The chromium side changes are:
http://codereview.chromium.org/6928021/ (needs to be landed first)
and
http://codereview.chromium.org/6930029/ (can be landed once this the webkit change is landed)

[Adam Barth]

Comment on attachment 92350 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92350&action=review

> Source/WebCore/platform/android/SSLKeyGeneratorAndroid.cpp:29
> +#include "Document.h"

The platform directory cannot include files from WebCore that are outside the platform directory.

Your root problem is that you need to go "up" to the client, not down to the platform, to solve this problem.

[Alexey Proskuryakov]

> In Chromium Linux we have to be able to show a dialog to unlock crypto devices when doing a keygen 

I'm curious what this dialog is about. Does it need to be displayed before any call to WTF::cryptographicallyRandomNumber()?

[Adam Barth]

> I'm curious what this dialog is about. Does it need to be displayed before any call to WTF::cryptographicallyRandomNumber()?

I'm not entirely sure, but I think "crypto devices" means something like a smart card.

[Matt Mueller]

Yes, this is about unlocking a smart card or password-protected software security device before doing the keygen.

[Ryosuke Niwa]

We should just remove this element: https://bugs.webkit.org/show_bug.cgi?id=167018