Bug 60224

Summary: [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: New BugsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+, kling: commit-queue-

Description Alexis Menard (darktears) 2011-05-04 16:01:23 PDT
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Comment 1 Alexis Menard (darktears) 2011-05-04 16:05:52 PDT
Created attachment 92339 [details]
Patch
Comment 2 Alexis Menard (darktears) 2011-05-04 16:06:34 PDT
See RenderTheme.cpp to double check what I'm saying.
Comment 3 Andreas Kling 2011-05-05 06:43:48 PDT
Comment on attachment 92339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92339&action=review

Did you performance test this?

> Source/WebCore/ChangeLog:9
> +        but webkit already have a nullptr class if there is no c++0x support.

webkit -> WebKit
have -> has

> Source/WebKit/qt/ChangeLog:9
> +        We should use nullptr rather than 0. nullptr will be added in the new C++ standard
> +        but webkit already have a nullptr class if there is no c++0x support.

Ditto.
Comment 4 Alexis Menard (darktears) 2011-05-05 07:14:34 PDT
Committed r85851: <http://trac.webkit.org/changeset/85851>