| Summary: | Add didNotHandleWheelEvent callback to WKPageUIClient | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeff Miller <jeffm> | ||||||||
| Component: | WebKit2 | Assignee: | Jeff Miller <jeffm> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | webkit-ews, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jeff Miller
2011-05-04 12:55:15 PDT
Created attachment 92306 [details]
Patch
Attachment 92306 [details] did not build on qt: Build output: http://queues.webkit.org/results/8558613 Comment on attachment 92306 [details]
Patch
I'll upload a new patch to fix the qt build.
Attachment 92306 [details] did not build on mac: Build output: http://queues.webkit.org/results/8551607 and the Mac build. Created attachment 92318 [details]
Patch
Attachment 92318 [details] did not build on qt: Build output: http://queues.webkit.org/results/8554660 Comment on attachment 92318 [details]
Patch
Still broke the qt build. But Adam Roben pointed out a simpler solution that doesn't involve adding a new callback, so I'm going to look at doing that.
I wrote up bug 60220 to track how I'm really going to address unhandled wheel events, closing this bug. Looks like sending the wheel message to the parent window isn't good enough, so I'm re-opening this bug. Created attachment 92360 [details]
Patch
Comment on attachment 92360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92360&action=review > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:429 > +void PageClientImpl::didNotHandleWheelEvent(const NativeWebWheelEvent& event) We normally leave out the names of unused arguments. Committed r85860: <http://trac.webkit.org/changeset/85860> |