Bug 60203

Summary: Add didNotHandleWheelEvent callback to WKPageUIClient
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: WebKit2Assignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Jeff Miller
Reported 2011-05-04 12:55:15 PDT
Add didNotHandleWheelEvent callback to WKPageUIClient
Attachments
Patch (18.23 KB, patch)
2011-05-04 13:12 PDT, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (20.21 KB, patch)
2011-05-04 14:47 PDT, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (13.54 KB, patch)
2011-05-04 19:26 PDT, Jeff Miller 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-05-04 13:12:56 PDT
Created attachment 92306 [details] Patch
Early Warning System Bot
Comment 2 2011-05-04 13:23:23 PDT
Attachment 92306 [details] did not build on qt: Build output: http://queues.webkit.org/results/8558613
Jeff Miller
Comment 3 2011-05-04 13:24:51 PDT
Comment on attachment 92306 [details] Patch I'll upload a new patch to fix the qt build.
WebKit Review Bot
Comment 4 2011-05-04 13:28:04 PDT
Attachment 92306 [details] did not build on mac: Build output: http://queues.webkit.org/results/8551607
Jeff Miller
Comment 5 2011-05-04 13:29:05 PDT
and the Mac build.
Jeff Miller
Comment 6 2011-05-04 14:47:51 PDT
Created attachment 92318 [details] Patch
Early Warning System Bot
Comment 7 2011-05-04 14:59:53 PDT
Attachment 92318 [details] did not build on qt: Build output: http://queues.webkit.org/results/8554660
Jeff Miller
Comment 8 2011-05-04 15:02:16 PDT
Comment on attachment 92318 [details] Patch Still broke the qt build. But Adam Roben pointed out a simpler solution that doesn't involve adding a new callback, so I'm going to look at doing that.
Jeff Miller
Comment 9 2011-05-04 15:39:51 PDT
I wrote up bug 60220 to track how I'm really going to address unhandled wheel events, closing this bug.
Jeff Miller
Comment 10 2011-05-04 19:00:57 PDT
Looks like sending the wheel message to the parent window isn't good enough, so I'm re-opening this bug.
Jeff Miller
Comment 11 2011-05-04 19:26:13 PDT
Created attachment 92360 [details] Patch
Darin Adler
Comment 12 2011-05-05 09:34:08 PDT
Comment on attachment 92360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92360&action=review > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:429 > +void PageClientImpl::didNotHandleWheelEvent(const NativeWebWheelEvent& event) We normally leave out the names of unused arguments.
Jeff Miller
Comment 13 2011-05-05 09:57:56 PDT
Committed r85860: <http://trac.webkit.org/changeset/85860>
Note You need to log in before you can comment on or make changes to this bug.