Bug 60203

Summary: Add didNotHandleWheelEvent callback to WKPageUIClient
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: WebKit2Assignee: Jeff Miller <jeffm>
Severity: Normal CC: webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch darin: review+

Description Jeff Miller 2011-05-04 12:55:15 PDT
Add didNotHandleWheelEvent callback to WKPageUIClient
Comment 1 Jeff Miller 2011-05-04 13:12:56 PDT
Created attachment 92306 [details]
Comment 2 Early Warning System Bot 2011-05-04 13:23:23 PDT
Attachment 92306 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8558613
Comment 3 Jeff Miller 2011-05-04 13:24:51 PDT
Comment on attachment 92306 [details]

I'll upload a new patch to fix the qt build.
Comment 4 WebKit Review Bot 2011-05-04 13:28:04 PDT
Attachment 92306 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8551607
Comment 5 Jeff Miller 2011-05-04 13:29:05 PDT
and the Mac build.
Comment 6 Jeff Miller 2011-05-04 14:47:51 PDT
Created attachment 92318 [details]
Comment 7 Early Warning System Bot 2011-05-04 14:59:53 PDT
Attachment 92318 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8554660
Comment 8 Jeff Miller 2011-05-04 15:02:16 PDT
Comment on attachment 92318 [details]

Still broke the qt build.  But Adam Roben pointed out a simpler solution that doesn't involve adding a new callback, so I'm going to look at doing that.
Comment 9 Jeff Miller 2011-05-04 15:39:51 PDT
I wrote up bug 60220 to track how I'm really going to address unhandled wheel events, closing this bug.
Comment 10 Jeff Miller 2011-05-04 19:00:57 PDT
Looks like sending the wheel message to the parent window isn't good enough, so I'm re-opening this bug.
Comment 11 Jeff Miller 2011-05-04 19:26:13 PDT
Created attachment 92360 [details]
Comment 12 Darin Adler 2011-05-05 09:34:08 PDT
Comment on attachment 92360 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=92360&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:429
> +void PageClientImpl::didNotHandleWheelEvent(const NativeWebWheelEvent& event)

We normally leave out the names of unused arguments.
Comment 13 Jeff Miller 2011-05-05 09:57:56 PDT
Committed r85860: <http://trac.webkit.org/changeset/85860>