Bug 60196

Summary:

sheriff-bot can't parse results.html

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dpranke, eric, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ojan: review+, ojan: commit-queue+

Adam Barth

Reported 2011-05-04 11:57:41 PDT

Traceback (most recent call last): File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 96, in run work_item = self._delegate.next_work_item() File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py", line 69, in next_work_item failure_map = self._tool.buildbot.failure_map() File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 451, in failure_map regression_window = builder.find_blameworthy_regression_window(builder_status["build_number"]) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 203, in find_blameworthy_regression_window regression_window = self.find_regression_window(red_build, look_back_limit) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 176, in find_regression_window results = current_build.layout_test_results() File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 257, in layout_test_results self._layout_test_results = LayoutTestResults.results_from_string(self._fetch_results_html()) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 138, in results_from_string test_results = ORWTResultsHTMLParser.parse_results_html(string) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 122, in parse_results_html tables = BeautifulSoup(page).findAll("table") File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1499, in __init__ BeautifulStoneSoup.__init__(self, *args, **kwargs) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1230, in __init__ self._feed(isHTML=isHTML) File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 1263, in _feed self.builder.feed(markup) File "/usr/lib/python2.6/HTMLParser.py", line 108, in feed self.goahead(0) File "/usr/lib/python2.6/HTMLParser.py", line 150, in goahead k = self.parse_endtag(i) File "/usr/lib/python2.6/HTMLParser.py", line 317, in parse_endtag self.error("bad end tag: %r" % (rawdata[i:j],)) File "/usr/lib/python2.6/HTMLParser.py", line 115, in error raise HTMLParseError(message, self.getpos()) HTMLParseError: bad end tag: u"</' + tagName + '>", at line 219, column 111

Attachments
Patch (44.72 KB, patch) 2011-05-04 12:38 PDT, Eric Seidel (no email)	ojan: review+ ojan: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2011-05-04 12:17:20 PDT

I suspect this is the NRWT bot, but I don't know.

Eric Seidel (no email)

Comment 2 2011-05-04 12:18:39 PDT

Yup. I'm able to repro this locally using failure-reason. Will write up a patch. We should also make the NRWT bots non-core.

Eric Seidel (no email)

Comment 3 2011-05-04 12:38:21 PDT

Created attachment 92301 [details] Patch

Ojan Vafai

Comment 4 2011-05-04 13:22:27 PDT

Comment on attachment 92301 [details] Patch rubber-stamp

Eric Seidel (no email)

Comment 5 2011-05-04 15:02:44 PDT

Committed r85792: <http://trac.webkit.org/changeset/85792>

Note You need to log in before you can comment on or make changes to this bug.