Bug 60192

Summary:

Web Inspector: add test for shadow DOM access in the console API

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	yurys: review+

Andrey Kosyakov

Reported 2011-05-04 11:44:13 PDT

We don't expose shadow DOM to JS normally, yet now that we show it in Elements panel, it may be accessed with $0. This test so far is the only place where we assure that a JS wrapper is properly created for shadow root and other shadow nodes. This is supposed to guard against things like bug 60026

Attachments
patch (4.94 KB, patch) 2011-05-04 11:46 PDT, Andrey Kosyakov	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2011-05-04 11:46:30 PDT

Created attachment 92292 [details] patch

Yury Semikhatsky

Comment 2 2011-05-05 03:33:25 PDT

Comment on attachment 92292 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=92292&action=review > LayoutTests/http/tests/inspector/elements-test.js:81 > +InspectorTest.selectNode = function(node, callback) Can you change InspectorTest.selectNodeWithId to call this method as well? > LayoutTests/inspector/console/console-shadow-dom-access.html:25 > + expressions.splice(0, 1); var expression = expressions.shift()

Andrey Kosyakov

Comment 3 2011-05-05 05:16:16 PDT

Manually committed a version with yurys' suggestions at r85849: http://trac.webkit.org/changeset/85849

Note You need to log in before you can comment on or make changes to this bug.