Bug 60176

Summary: [Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Pierre Rossi <pierre.rossi>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, benjamin, joel.parks, kling, laszlo.gombos, ossy, qi.2.zhang
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   

Description Csaba Osztrogonác 2011-05-04 09:18:30 PDT
http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html
fails with Qt 4.8 HEAD, but passes with released Qt 4.7.2 .
Comment 1 Csaba Osztrogonác 2011-05-04 09:18:42 PDT
--- /ramdisk/qt-linux-32-release-qt470/build/layout-test-results/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt	2011-05-04 08:29:22.005729286 -0700
+++ /ramdisk/qt-linux-32-release-qt470/build/layout-test-results/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-actual.txt	2011-05-04 08:29:22.005729286 -0700
@@ -2,7 +2,7 @@
 
 PASS: No exception.
 readyState: 4 (number)
-responseText: Non-empty (string)
+responseText:  (string)
 responseXML: null (object)
 status: 404 (number)
 statusText: Not Found (string)
Comment 2 Csaba Osztrogonác 2011-05-10 06:52:10 PDT
Skipped by http://trac.webkit.org/changeset/86148 and http://trac.webkit.org/changeset/86149
Comment 3 Csaba Osztrogonác 2011-05-10 06:57:36 PDT
and http://trac.webkit.org/changeset/86149

Pfff, it isn't my day .... :((
Comment 5 Csaba Osztrogonác 2011-05-27 05:46:52 PDT
Qt bug report filed about it: http://bugreports.qt.nokia.com/browse/QTBUG-19556
Comment 6 Joel Parks 2011-06-22 07:11:15 PDT
Qt bug report has been set to NEEDS MORE INFO, as the Qt team is apparently unable to proceed with reproducing the problem.
Comment 7 Joel Parks 2011-06-27 12:09:20 PDT
an update in the Qt bug report:

Pierre Rossi added a comment - 27/Jun/11 8:55 PM
@Joel: Could you try if this makes things better for you ?

diff --git a/src/network/access/qnetworkaccesshttpbackend.cpp b/src/network/access/qnetworkaccesshttpbackend.cpp
index 64a22aa..7d49648 100644
--- a/src/network/access/qnetworkaccesshttpbackend.cpp
+++ b/src/network/access/qnetworkaccesshttpbackend.cpp
@@ -653,6 +653,7 @@ void QNetworkAccessHttpBackend::postRequest()
                      delegate->isPipeliningUsed,
                      QSharedPointer<char>(),
                      delegate->incomingContentLength);
+            replyDownloadData(delegate->synchronousDownloadData);
             httpError(delegate->incomingErrorCode, delegate->incomingErrorDetail);
         } else {
             replyDownloadMetaData

Is someone in a position to try this and see if it affects the issue?
Comment 8 Pierre Rossi 2011-06-28 05:00:59 PDT
This is now fixed in Qt by commit 7590cfcea9d40e59af8edd7cdd3d11ffbc5aaa04 that'll be in for 4.8.0.
Comment 9 Csaba Osztrogonác 2011-06-28 05:07:24 PDT
Reopen not to forget to unskip this test after we updated Qt on the bots.
Comment 10 Csaba Osztrogonác 2011-07-14 07:59:35 PDT
Unskipped in trunk by https://trac.webkit.org/changeset/91000
Comment 11 Ademar Reis 2011-08-05 13:01:32 PDT
(In reply to comment #10)
> Unskipped in trunk by https://trac.webkit.org/changeset/91000

Closing bug as FIXED, since the it was fixed in Qt and the test was unskipped in trunk.

The unskip has not been cherry-picked into 2.2 yet because we still need to update Qt-4.8 there (non-trivial, involves a lot of test rebasing, we'll do it once we're closer to a Qt-4.8 RC).
Comment 12 Ademar Reis 2011-08-05 13:14:29 PDT
The problem has been fixed in Qt, this bug is now just about a test to be unskipped, not release-critical for qtwebkit-2.2, nice-to-have instead.
Comment 13 Ademar Reis 2011-09-13 14:22:11 PDT
The test has been skipped in the qtwebkit-2.2 branch as well.