Bug 60162

Summary: [NRWT] chromium-linux tests shouldn't run on other platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Kristóf Kosztyó <kkristof>
Status: RESOLVED FIXED    
Severity: Normal CC: kkristof, ossy, rgabor
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
proposed fix none

Description Csaba Osztrogonác 2011-05-04 05:56:42 PDT
These tests run, but they shouldn't:

platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

Gábor, could you check it, please?
Comment 1 Kristóf Kosztyó 2011-05-13 07:40:31 PDT
Created attachment 93449 [details]
proposed fix
Comment 2 Csaba Osztrogonác 2011-05-13 07:43:49 PDT
Comment on attachment 93449 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=93449&action=review

LGTM, r=me with a little fix in changelog

> Tools/ChangeLog:9
> +        Remove _tests_for_other_platforms defs because in the r82753
> +        it is implemented properly in the baseclass in webkit.py

little nit: ... because r82753 implemented it properly ...
Comment 3 Csaba Osztrogonác 2011-05-13 07:48:57 PDT
Landed in http://trac.webkit.org/changeset/86429