Bug 60151

Summary: [EFL] Remove ewk_tile_unused_cache_free function from public API
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dbates, eric, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Tomasz Morawski
Reported 2011-05-04 02:55:08 PDT
The ewk_tile_unused_cache_free function should be only called by ewk_tile_unused_cache_unref function. Calling this function without considering reference counting may lead to fatal results.
Attachments
Patch (2.73 KB, patch)
2011-05-04 02:57 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2011-05-04 02:57:26 PDT
Created attachment 92207 [details] Patch
Lucas De Marchi
Comment 2 2011-05-04 14:51:57 PDT
Comment on attachment 92207 [details] Patch LGTM
Daniel Bates
Comment 3 2011-05-07 14:55:47 PDT
Comment on attachment 92207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92207&action=review > Source/WebKit/efl/ChangeLog:5 > + [EFL] Remove ewk_tile_unused_cache_free function form public api form => from
Daniel Bates
Comment 4 2011-05-07 14:57:07 PDT
Comment on attachment 92207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92207&action=review >> Source/WebKit/efl/ChangeLog:5 >> + [EFL] Remove ewk_tile_unused_cache_free function form public api > > form => from api => API
WebKit Commit Bot
Comment 5 2011-05-07 16:35:13 PDT
Comment on attachment 92207 [details] Patch Clearing flags on attachment: 92207 Committed r86012: <http://trac.webkit.org/changeset/86012>
WebKit Commit Bot
Comment 6 2011-05-07 16:35:16 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-05-07 19:50:21 PDT
http://trac.webkit.org/changeset/86012 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg
WebKit Review Bot
Comment 8 2011-05-07 19:50:34 PDT
http://trac.webkit.org/changeset/86014 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg
Note You need to log in before you can comment on or make changes to this bug.