Bug 60149

Summary: [EFL] Added error check for _ewk_init_body result.
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, gyuyoung.kim, kenneth, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Fixed patch none

Description Tomasz Morawski 2011-05-04 02:37:44 PDT 
The ewk_init function should be failed when _ewk_init_body function return false.
Comment 1 Tomasz Morawski 2011-05-04 02:38:26 PDT 
Created attachment 92205 [details]
Patch
Comment 2 Tomasz Morawski 2011-05-04 02:42:58 PDT 
Change platform
Comment 3 Eric Seidel (no email) 2011-05-04 02:49:06 PDT 
Attachment 92205 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tomasz Morawski 2011-05-04 03:04:15 PDT 
Created attachment 92209 [details]
Fixed patch
Comment 5 Gyuyoung Kim 2011-05-04 03:09:53 PDT 
LGTM.
Comment 6 Kenneth Rohde Christiansen 2011-05-04 03:46:12 PDT 
Comment on attachment 92209 [details]
Fixed patch

I guess that is ok
Comment 7 Gyuyoung Kim 2011-05-04 04:27:33 PDT 
Lucas,

How do you think about this patch ?
Comment 8 Lucas De Marchi 2011-05-04 14:48:17 PDT 
Comment on attachment 92209 [details]
Fixed patch

LGTM
Comment 9 WebKit Commit Bot 2011-05-04 16:34:16 PDT 
Comment on attachment 92209 [details]
Fixed patch

Clearing flags on attachment: 92209

Committed r85804: <http://trac.webkit.org/changeset/85804>
Comment 10 WebKit Commit Bot 2011-05-04 16:34:22 PDT 
All reviewed patches have been landed.  Closing bug.