Bug 60098

Summary: Replace calls to isInline() && !isInlineBlockOrInlineTable() by isRenderInline()
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED LATER    
Severity: Enhancement CC: ahmad.saleem792, eric, hyatt, jamesr, leviw, simon.fraser, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
cleanup none

Ryosuke Niwa
Reported 2011-05-03 17:55:09 PDT
This is a cleanup
Attachments
cleanup (2.62 KB, patch)
2011-05-03 17:59 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-05-03 17:59:19 PDT
Created attachment 92178 [details] cleanup
James Robinson
Comment 2 2011-05-03 19:20:32 PDT
Comment on attachment 92178 [details] cleanup This is not just a straight rename - they two functions do slightly different things. isRenderInline() checks only the type of a RenderObject whereas isInlineBlockOrInlineTable() also checks member variables on the object (such as m_replaced). I'm not saying this patch is wrong but it is not completely mechanical.
Ryosuke Niwa
Comment 3 2011-05-03 19:22:08 PDT
(In reply to comment #2) > (From update of attachment 92178 [details]) > This is not just a straight rename - they two functions do slightly different things. isRenderInline() checks only the type of a RenderObject whereas isInlineBlockOrInlineTable() also checks member variables on the object (such as m_replaced). I'm not saying this patch is wrong but it is not completely mechanical. What do you want me to do?
James Robinson
Comment 4 2011-05-06 21:15:08 PDT
To start, explain why the change is correct in the ChangeLog.
Ryosuke Niwa
Comment 5 2011-05-06 21:26:28 PDT
Comment on attachment 92178 [details] cleanup (In reply to comment #4) > To start, explain why the change is correct in the ChangeLog. Ugh... too much work. Someone else should take this bug.
Ahmad Saleem
Comment 6 2024-03-30 17:53:05 PDT
We still have few cases like these e.g.: https://searchfox.org/wubkat/rev/da53e5336a9c4f2e056e219a184c4f908cda7f02/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#651 Do we need this clean-up or IFC and NG Layout work will tackle it slowly? @Alan - any input?
zalan
Comment 7 2024-03-30 18:01:30 PDT
(In reply to Ahmad Saleem from comment #6) > We still have few cases like these e.g.: > > https://searchfox.org/wubkat/rev/da53e5336a9c4f2e056e219a184c4f908cda7f02/ > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#651 > > Do we need this clean-up or IFC and NG Layout work will tackle it slowly? > > @Alan - any input? Yeah LFC is going to take care of it. No need to rush it.
Note You need to log in before you can comment on or make changes to this bug.