| Summary: | Crash in SpellingCorrectionController::respondToChangedSelection | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
| Component: | HTML Editing | Assignee: | Enrica Casucci <enrica> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, rniwa | ||||
| Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Enrica Casucci
2011-05-03 15:27:08 PDT
Created attachment 92152 [details]
Patch
Comment on attachment 92152 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92152&action=review > Source/WebCore/editing/SpellingCorrectionController.cpp:390 > + // Creating a Visible position triggers a layout and there is no > + // guarantee that the selection is still valid. Seems odd that layout cases a position to become null but okay. Is the _selection_ actually becoming invalid? The comment seems slightly confusing. The selection is in a text field that gets hidden. The spelling code builds a VisiblePosition from the start position of the selection, producing a null position. Comment on attachment 92152 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92152&action=review > LayoutTests/editing/selection/undo-crash-expected.txt:2 > +SUCCEEDED PASS might be more consistent with the rest of editing tests. (In reply to comment #4) > The selection is in a text field that gets hidden. The spelling code builds a VisiblePosition from the start position of the selection, producing a null position. Makes sense. |