Summary: | Update rebaseline queue server to handle hierarchical test results | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||
Component: | Tools / Tests | Assignee: | Mihai Parparita <mihaip> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ojan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Mihai Parparita
2011-05-03 14:18:17 PDT
Created attachment 92130 [details]
Patch
Comment on attachment 92130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92130&action=review Whoops. Sorry. I thought I found all the places that read in the results. > Tools/RebaselineQueueServer/templates/builder-queue-edit.html:59 > + console.dir(results); Did you mean to leave this in? > Tools/RebaselineQueueServer/templates/builder-queue-edit.html:72 > + if (actual != expected && > + expected.split(' ').indexOf(actual) == -1 && > + actual != 'SKIP' && > + actual.indexOf('PASS') == -1 && > + (expected.indexOf('FAIL') == -1 || actual.indexOf('TIMEOUT') != -1)) { > + results.name = test; nit: i prefer the old code if you changed the continue to an early return. But your call. (In reply to comment #2) > Did you mean to leave this in? Nope, removed. > nit: i prefer the old code if you changed the continue to an early return. But your call. Yeah, that's better. Switched back. Committed r85692: <http://trac.webkit.org/changeset/85692> |