Bug 60053

Summary: Testing OwnPtrs for equality should cause a compiler error
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: PlatformAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, darin, dglazkov, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
andersca: review+
updated patch koivisto: review+

Description Adam Roben (:aroben) 2011-05-03 12:43:03 PDT 
Testing OwnPtrs for equality should cause a compiler error
Comment 1 Adam Roben (:aroben) 2011-05-03 12:45:41 PDT 
Created attachment 92108 [details]
patch
Comment 2 Early Warning System Bot 2011-05-03 13:01:15 PDT 
Attachment 92108 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8538131
Comment 3 Adam Roben (:aroben) 2011-05-03 13:16:00 PDT 
Comment on attachment 92108 [details]
patch

This patch is incomplete. We have existing code that does equality comparisons on OwnPtrs that this patch breaks. I'll upload a new patch that fixes the errors I can see on Windows, and then we'll let EWS chew on it.
Comment 4 Adam Roben (:aroben) 2011-05-03 13:42:35 PDT 
Created attachment 92118 [details]
updated patch

This patch compiles on Windows. We'll see about other ports! (Thanks, EWS!)
Comment 5 WebKit Review Bot 2011-05-03 13:45:01 PDT 
Attachment 92118 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Adam Roben (:aroben) 2011-05-03 13:47:28 PDT 
Comment on attachment 92118 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92118&action=review

>> Source/WebKit2/ChangeLog:1
>>  2011-05-03  Adam Roben  <aroben@apple.com>
> 
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

Whoops, I'll fix this.
Comment 7 WebKit Review Bot 2011-05-03 15:15:02 PDT 
Attachment 92108 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8532632
Comment 8 Antti Koivisto 2011-05-04 06:59:17 PDT 
Comment on attachment 92118 [details]
updated patch

COMPILE_ASSERT instead of (void)"foo" thing perhaps?
Comment 9 Adam Roben (:aroben) 2011-05-04 07:34:57 PDT 
(In reply to comment #8)
> (From update of attachment 92118 [details])
> COMPILE_ASSERT instead of (void)"foo" thing perhaps?

I took this suggestion but foolishly didn't let it go through EWS before committing.

Fixed in r85746, r85748, and r85749.