Bug 60031

Summary: Web Inspector: can't inspect element in an iframe when element originates from non-frame document
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Patch for landing none

Description Yury Semikhatsky 2011-05-03 09:07:20 PDT 
What steps will reproduce the problem?
1. Open http://kangax.github.com/jstests/iframe-createElement-web-inspector/
2. Try inspecting both elements in an iframe
3. One of the elements can't be inspected

This seems to be due to an element originating from context other than iframe's context (i.e. created via <main document>.createElement rather than <iframe document>.createElement).

Original Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=77453
Comment 1 Yury Semikhatsky 2011-05-03 09:14:35 PDT 
Created attachment 92084 [details]
Patch
Comment 2 Pavel Feldman 2011-05-03 10:05:30 PDT 
Comment on attachment 92084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92084&action=review

> Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:102
> +        return jsBoolean(true);

return jsUndefined() ?
Comment 3 Yury Semikhatsky 2011-05-03 23:04:14 PDT 
Created attachment 92196 [details]
Patch for landing

Review comments addressed.
Comment 4 Yury Semikhatsky 2011-05-03 23:45:59 PDT 
Committed r85722: <http://trac.webkit.org/changeset/85722>