Bug 60025

Summary: Windows should (almost) build with strict PassOwnPtr enabled
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: PlatformAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch andersca: review+

Adam Roben (:aroben)
Reported 2011-05-03 08:02:45 PDT
Windows should build with strict PassOwnPtr enabled. But there are some tricky issues related to SimpleFontData::scaledFontData, so this bug will represent every issue except for that one.
Attachments
patch (18.27 KB, patch)
2011-05-03 08:18 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-05-03 08:18:19 PDT
Created attachment 92078 [details] patch
Adam Roben (:aroben)
Comment 2 2011-05-03 13:52:34 PDT
Committed r85653: <http://trac.webkit.org/changeset/85653>
Darin Adler
Comment 3 2011-05-03 13:52:47 PDT
Comment on attachment 92078 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=92078&action=review > Source/WebKit/win/WebCoreSupport/WebInspectorClient.h:98 > + ~WebInspectorFrontendClient(); This should be explicitly marked virtual.
Adam Roben (:aroben)
Comment 4 2011-05-03 13:53:32 PDT
Comment on attachment 92078 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=92078&action=review >> Source/WebKit/win/WebCoreSupport/WebInspectorClient.h:98 >> + ~WebInspectorFrontendClient(); > > This should be explicitly marked virtual. Thanks for catching that! I'll fix it in a followup.
Note You need to log in before you can comment on or make changes to this bug.