Bug 60000

Summary:

WebKit allows selection that crosses the shadow boundary of a readonly input element

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Major

CC:

adele, ap, commit-queue, darin, dglazkov, enrica, rolandsteiner, sam, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

59435

Attachments:

Description	Flags
demo	none
DRT test	none
fixes the bug	none
fixed select-across-readonly-input-5.html	none

Ryosuke Niwa

Reported 2011-05-02 18:31:18 PDT

In the attached document, you can create a selection starting inside an input element and ending outside of the input element by a mouse drag.

Attachments
demo (90 bytes, text/html) 2011-05-02 18:31 PDT, Ryosuke Niwa	no flags	Details
DRT test (3.54 KB, text/html) 2011-05-02 22:14 PDT, Ryosuke Niwa	no flags	Details
fixes the bug (218.61 KB, patch) 2011-05-02 22:43 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
fixed select-across-readonly-input-5.html (218.90 KB, patch) 2011-05-02 22:48 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2011-05-02 18:31:39 PDT

Created attachment 92029 [details] demo

Alexey Proskuryakov

Comment 2 2011-05-02 21:27:51 PDT

This is not a regression from Safari 5. I actually wonder if it's a bug or intended behavior.

Ryosuke Niwa

Comment 3 2011-05-02 21:34:23 PDT

(In reply to comment #2) > This is not a regression from Safari 5. I actually wonder if it's a bug or intended behavior. I don't think this can be an intended behavior. SelectionController has a selection that crosses the shadow boundary.

Ryosuke Niwa

Comment 4 2011-05-02 21:36:20 PDT

For what's worth, window.getSelection().toString() returns "" and baseNode and extentExtent of DOMSelection report incorrect nodes.

Alexey Proskuryakov

Comment 5 2011-05-02 21:54:33 PDT

See also: bug 7275 (not very closely related).

Ryosuke Niwa

Comment 6 2011-05-02 22:14:59 PDT

Created attachment 92046 [details] DRT test Here's a half-baked DRT test. I'm going to abandon this test and write a bunch of pixel tests because it can only indirectly check the behavior and it's not suitable as a regression test.

Ryosuke Niwa

Comment 7 2011-05-02 22:43:46 PDT

Created attachment 92049 [details] fixes the bug

Ryosuke Niwa

Comment 8 2011-05-02 22:48:16 PDT

Created attachment 92050 [details] fixed select-across-readonly-input-5.html

WebKit Commit Bot

Comment 9 2011-05-03 15:12:31 PDT

The commit-queue encountered the following flaky tests while processing attachment 92050 [details]: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 10 2011-05-03 15:14:58 PDT

Comment on attachment 92050 [details] fixed select-across-readonly-input-5.html Clearing flags on attachment: 92050 Committed r85669: <http://trac.webkit.org/changeset/85669>

WebKit Commit Bot

Comment 11 2011-05-03 15:15:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.