Bug 59997 – webkitpy has weird layering problems now that break test-webkitpy on win32, cause other problems

• Component: Tools / Tests
• Status: NEW

[Dirk Pranke]

I'm not sure if this was introduced by Eric's refactoring of scm and net/bugzilla, or has been broken longer, but

1) I can no longer run test-webkitpy inside a win32 cmd shell

2) I can no longer run specific subsets of the tests by hand, e.g., using 'test-webkitpy webkitpy.common.net.bugzilla.bugzilla_unittest'

3) I can't directly import common.net.bugzilla ; we seem to get circular references. The output is:

$ python
Python 2.6.1 (r261:67515, Jun 24 2010, 21:47:49) 
[GCC 4.2.1 (Apple Inc. build 5646)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import webkitpy.common.net.bugzilla
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Volumes/Src/src/dev/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py", line 5, in <module>
    from .bugzilla import Bugzilla, parse_bug_id, parse_bug_id_from_changelog
  File "/Volumes/Src/src/dev/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 46, in <module>
    from webkitpy.common.net.credentials import Credentials
  File "/Volumes/Src/src/dev/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/credentials.py", line 36, in <module>
    from webkitpy.common.checkout.scm import Git
  File "/src/dev/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/__init__.py", line 3, in <module>
    from .checkout import Checkout
  File "/src/dev/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 33, in <module>
    from webkitpy.common.checkout.changelog import ChangeLog
  File "/Volumes/Src/src/dev/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 39, in <module>
    from webkitpy.common.net.bugzilla import parse_bug_id_from_changelog
ImportError: cannot import name parse_bug_id_from_changelog
>>>

We appear to have a circular import.

I'm not sure why test-webkitpy is working on non-win32 ports, but I'm guessing they happen to load the test files in a particular order that allows things to work.

[Adam Barth]

I broke it.  Checkout should not depend on net.  parse_bug_id_from_changelog probably needs to move to changelog.py, probably as a member function.