Summary: | CoreIPC/ArgumentDecoder should use aligned memory for its internal copy of data | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||||
Component: | WebKit2 | Assignee: | Siddharth Mathur <s.mathur> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ap, commit-queue, darin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | S60 Hardware | ||||||||
OS: | S60 3rd edition | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 50251 | ||||||||
Attachments: |
|
Description
Siddharth Mathur
2011-05-02 14:11:54 PDT
Created attachment 92080 [details]
Patch
Comment on attachment 92080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92080&action=review > Source/WebKit2/ChangeLog:1 > +2011-05-03 Siddharth Mathur <siddharth mathur> No e-mail address here. > Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.cpp:71 > + m_buffer = roundUpToAlignment(m_allocatedBase, expectedAlignment); If you want, you can assert that m_buffer is aligned here. Created attachment 92114 [details]
Patch with assert and fixed Changelog
The commit-queue encountered the following flaky tests while processing attachment 92114 [details]: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 92114 [details] Patch with assert and fixed Changelog Clearing flags on attachment: 92114 Committed r85755: <http://trac.webkit.org/changeset/85755> All reviewed patches have been landed. Closing bug. |