Bug 59953

Summary:

Port Mozilla's IndexedDB tests: adding and removing values

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dgrogan, fishd, hans, pilgrim, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Updated test description	none

Mark Pilgrim (Google)

Reported 2011-05-02 12:12:58 PDT

Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectStore_remove_values.html?raw=1 This is a port of a test from Mozilla's IndexedDB test suite. It adds, gets, deletes, and re-gets a record in a variety of different object store configurations. WebKit passes this test.

Attachments
Patch (8.24 KB, patch) 2011-05-02 12:15 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Patch (8.39 KB, patch) 2011-05-02 13:35 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Patch (11.45 KB, patch) 2011-05-02 13:45 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Updated test description (8.39 KB, patch) 2011-05-02 13:57 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mark Pilgrim (Google)

Comment 1 2011-05-02 12:15:04 PDT

Created attachment 91954 [details] Patch

Tony Chang

Comment 2 2011-05-02 12:30:25 PDT

Comment on attachment 91954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91954&action=review > LayoutTests/storage/indexeddb/mozilla/object-store-remove-values.html:20 > +description("Test IndexedDB's creating and deleting indexes"); Is this description correct? I would just use the text from comment 0.

Mark Pilgrim (Google)

Comment 3 2011-05-02 13:35:19 PDT

Created attachment 91969 [details] Patch

Mark Pilgrim (Google)

Comment 4 2011-05-02 13:35:48 PDT

Fixed description.

Mark Pilgrim (Google)

Comment 5 2011-05-02 13:45:25 PDT

Created attachment 91973 [details] Patch

Mark Pilgrim (Google)

Comment 6 2011-05-02 13:46:44 PDT

Comment on attachment 91973 [details] Patch webkit-patch screwed up and attached a patch to the wrong bug, hang on a second.

Mark Pilgrim (Google)

Comment 7 2011-05-02 13:57:32 PDT

Created attachment 91976 [details] Updated test description This is the correct patch.

WebKit Commit Bot

Comment 8 2011-05-02 18:51:38 PDT

Comment on attachment 91976 [details] Updated test description Clearing flags on attachment: 91976 Committed r85574: <http://trac.webkit.org/changeset/85574>

WebKit Commit Bot

Comment 9 2011-05-02 18:51:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.