Bug 59953

Summary: Port Mozilla's IndexedDB tests: adding and removing values
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dgrogan, fishd, hans, pilgrim, tony
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Updated test description none

Description Mark Pilgrim (Google) 2011-05-02 12:12:58 PDT 
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectStore_remove_values.html?raw=1

This is a port of a test from Mozilla's IndexedDB test suite. It adds, gets, deletes, and re-gets a record in a variety of different object store configurations.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-05-02 12:15:04 PDT 
Created attachment 91954 [details]
Patch
Comment 2 Tony Chang 2011-05-02 12:30:25 PDT 
Comment on attachment 91954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91954&action=review

> LayoutTests/storage/indexeddb/mozilla/object-store-remove-values.html:20
> +description("Test IndexedDB's creating and deleting indexes");

Is this description correct?  I would just use the text from comment 0.
Comment 3 Mark Pilgrim (Google) 2011-05-02 13:35:19 PDT 
Created attachment 91969 [details]
Patch
Comment 4 Mark Pilgrim (Google) 2011-05-02 13:35:48 PDT 
Fixed description.
Comment 5 Mark Pilgrim (Google) 2011-05-02 13:45:25 PDT 
Created attachment 91973 [details]
Patch
Comment 6 Mark Pilgrim (Google) 2011-05-02 13:46:44 PDT 
Comment on attachment 91973 [details]
Patch

webkit-patch screwed up and attached a patch to the wrong bug, hang on a second.
Comment 7 Mark Pilgrim (Google) 2011-05-02 13:57:32 PDT 
Created attachment 91976 [details]
Updated test description

This is the correct patch.
Comment 8 WebKit Commit Bot 2011-05-02 18:51:38 PDT 
Comment on attachment 91976 [details]
Updated test description

Clearing flags on attachment: 91976

Committed r85574: <http://trac.webkit.org/changeset/85574>
Comment 9 WebKit Commit Bot 2011-05-02 18:51:43 PDT 
All reviewed patches have been landed.  Closing bug.