Summary: | Remove JmpSrc/JmpDst types. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fu, talking1239, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Barraclough
2011-05-01 14:44:03 PDT
Created attachment 91847 [details]
The patch
Attachment 91847 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:1197: jmp_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/AssemblerBuffer.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 2 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 91847 [details]
The patch
Please add a comment about why 2^32-1 is enough.
Hi Gavin, For MIPS build, we need to switch the order of header files to get it compiled. Thanks! Regards, Chao-ying fu@debian:/disk/fu/dev/WebKit/Source/JavaScriptCore/assembler$ svn diff Index: MacroAssemblerMIPS.h =================================================================== --- MacroAssemblerMIPS.h (revision 85498) +++ MacroAssemblerMIPS.h (working copy) @@ -29,8 +29,8 @@ #if ENABLE(ASSEMBLER) && CPU(MIPS) +#include "MIPSAssembler.h" #include "AbstractMacroAssembler.h" -#include "MIPSAssembler.h" namespace JSC { is exist some reason for using char* to replace void* in the getRelocatedAddress function of the sh4assembler.h file? |