Bug 59884

Summary: Move scm.py into its own module in preparation for splitting it up
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Description Eric Seidel (no email) 2011-05-01 12:14:02 PDT
Move scm.py into its own module in preparation for splitting it up
Comment 1 Eric Seidel (no email) 2011-05-01 12:18:04 PDT
Created attachment 91833 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-01 12:19:21 PDT
Attachment 91833 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 51, in <module>
    from webkitpy.style_references import detect_checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style_references.py", line 47, in <module>
    from webkitpy.common.checkout.scm import detect_scm_system
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py", line 4, in <module>
    from .scm import SCM, SVN, Git, CommitMessage, detect_scm_system, find_checkout_root, default_scm, AuthenticationError, AmbiguousCommitError, CheckoutNeedsUpdate
ImportError: No module named scm


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2011-05-01 12:19:36 PDT
Comment on attachment 91833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91833&action=review

> Tools/Scripts/webkitpy/test/main.py:153
> +        # unittest.main has horrible error reporting when module imports are bad
> +        # so we test import here to make debugging bad imports much easier.
> +        for module in modules:
> +            __import__(module)

Is this related?
Comment 4 Eric Seidel (no email) 2011-05-01 12:20:24 PDT
(In reply to comment #3)
> (From update of attachment 91833 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91833&action=review
> 
> > Tools/Scripts/webkitpy/test/main.py:153
> > +        # unittest.main has horrible error reporting when module imports are bad
> > +        # so we test import here to make debugging bad imports much easier.
> > +        for module in modules:
> > +            __import__(module)
> 
> Is this related?

It made it posible to track down the import problems with making changes like this.  It would have made tracking down your PIL problem super-easy.
Comment 5 Eric Seidel (no email) 2011-05-01 12:20:57 PDT
Committed r85427: <http://trac.webkit.org/changeset/85427>