Summary: | Pages with accelerated compositing do not redraw unless scrolled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Marrin <cmarrin> | ||||||
Component: | Layout and Rendering | Assignee: | Chris Marrin <cmarrin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | simon.fraser | ||||||
Priority: | P1 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Attachments: |
|
Description
Chris Marrin
2011-04-29 17:42:51 PDT
Created attachment 91777 [details]
Patch
Comment on attachment 91777 [details]
Patch
Why does Windows need this change but not Mac?
(In reply to comment #2) > (From update of attachment 91777 [details]) > Why does Windows need this change but not Mac? I thought about that. I haven't tried debugging this sequence of calls on Mac. But I'm assuming that there is some Mac specific code that does a setNeedsDIsplay() later in time. Or it could be that CA automatically dirties the layer when changing size and CACF doesn't. I don't think doing a setNeedsDisplay here will hurt Mac. But I could always rejigger the code a bit so this is only done on Windows. Comment on attachment 91777 [details]
Patch
I actually think we need it (see Radar comments).
Comment on attachment 91777 [details]
Patch
Actually, I think you should only repaint if it got larger, and then only the rects that were revealed.
Created attachment 91956 [details]
Patch
Landed in http://trac.webkit.org/changeset/85508 |