Summary: | Avoid allocating a new image buffer in ~CanvasRenderingContext2D() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Canvas | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, mdelaney7, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-04-29 17:35:21 PDT
Created attachment 92273 [details]
Patch
Comment on attachment 92273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92273&action=review > Source/WebCore/html/HTMLCanvasElement.h:103 > - GraphicsContext* drawingContext() const; > + enum ImageBufferCreation { AllowImageBufferCreation, DisallowImageBufferCreation }; > + GraphicsContext* drawingContext(ImageBufferCreation allowBufferCreation = AllowImageBufferCreation) const; Can we just add a second function with this behavior? Or maybe just a function that returns a boolean to tell us if we already have a buffer? I think that adding this argument is unnecessary given how simple the function is. Comment on attachment 92273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92273&action=review >> Source/WebCore/html/HTMLCanvasElement.h:103 >> + GraphicsContext* drawingContext(ImageBufferCreation allowBufferCreation = AllowImageBufferCreation) const; > > Can we just add a second function with this behavior? Or maybe just a function that returns a boolean to tell us if we already have a buffer? I think that adding this argument is unnecessary given how simple the function is. One possible name for a new function would be existingDrawingContext. But I think that the hasImageBuffer solution would be fine. Comment on attachment 92273 [details]
Patch
Yeah, sounds good.
Created attachment 92278 [details]
Patch
|