Bug 59848

Summary: [ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint
Product: WebKit Reporter: Chris Guillory <ctguil>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: brettw, commit-queue, darin, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Proposed Patch
none
Address issue uncovered by proposed Chromium test patch. none

Chris Guillory
Reported 2011-04-29 17:23:52 PDT
This issue was discovered while investigating http://crbug.com/80616. Looks like the call to endPlatformPaint should have been removed in this changeset 41978. http://trac.webkit.org/changeset/41978/trunk/WebCore/platform/graphics/chromium/FontChromiumWin.cpp.
Attachments
Patch (1.48 KB, patch)
2011-04-29 17:26 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Proposed Patch (1.68 KB, patch)
2011-05-06 18:45 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Address issue uncovered by proposed Chromium test patch. (2.11 KB, patch)
2011-05-10 15:34 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Guillory
Comment 1 2011-04-29 17:26:18 PDT
Created attachment 91771 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-01 09:52:04 PDT
Comment on attachment 91771 [details] Patch You might try webkit-patch upload for your next patch. It will automatically check the patch checkbox, etc. when uploading.
Eric Seidel (no email)
Comment 3 2011-05-01 09:52:57 PDT
Comment on attachment 91771 [details] Patch OK. How do we test this? Recently there was a RIAA added for GraphicsContext::save/restore which helped get rid of a bunch of bugs like this in the cross-platofrm code.
Eric Seidel (no email)
Comment 4 2011-05-01 09:54:37 PDT
Comment on attachment 91771 [details] Patch Seems we either need a test or an explanation of why testing is impossible in your ChangeLog. I don't think we can test printing with DumpRenderTree. So if printing is required to test this, automated testing may be impossible.
Chris Guillory
Comment 5 2011-05-06 18:31:10 PDT
One way to "test" would be to have the non-printing case fail (in debug mode) when this bug occurs. I have a Chromium change out for review for that. http://codereview.chromium.org/6949012/
Chris Guillory
Comment 6 2011-05-06 18:45:54 PDT
Created attachment 92675 [details] Proposed Patch Adding testing information.
Chris Guillory
Comment 7 2011-05-10 14:57:48 PDT
Comment on attachment 92675 [details] Proposed Patch Patch needs to be updated to address errors uncovered by chromium change.
Chris Guillory
Comment 8 2011-05-10 15:34:23 PDT
Created attachment 93030 [details] Address issue uncovered by proposed Chromium test patch. Adding testing information.
James Robinson
Comment 9 2011-05-10 15:41:54 PDT
Comment on attachment 93030 [details] Address issue uncovered by proposed Chromium test patch. Hurray for testing!
WebKit Commit Bot
Comment 10 2011-05-10 17:33:57 PDT
Comment on attachment 93030 [details] Address issue uncovered by proposed Chromium test patch. Clearing flags on attachment: 93030 Committed r86199: <http://trac.webkit.org/changeset/86199>
WebKit Commit Bot
Comment 11 2011-05-10 17:34:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.