| Summary: | AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Accessibility | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cfleizach, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
Attachment 91580 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 91580 [details]
Patch
looks ok, I assume you'll fix the change log. thanks r=me
Committed r85263: <http://trac.webkit.org/changeset/85263> |
Created attachment 91580 [details] Patch Reviewed by NOBODY (OOPS!). Previously, AXObjectCache::attachWrapper over-retained each AccessibilityObjectWrapper it created, which is why AXObjectCache::detachWrapper() contained an extra -release. * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::detachWrapper): Removed extra -release. (WebCore::AXObjectCache::attachWrapper): Because setWrapper() assigns to a RetainPtr<> instance variable, it doesn't need a +1 retained object passed in. Fix the leak by using a RetainPtr<> for the AccessibilityObjectWrapper. --- 2 files changed, 19 insertions(+), 2 deletions(-)