Bug 59748

Summary:

[chromium] support components build on Linux

Product:

WebKit

Reporter:

Evan Martin <evan>

Component:

New Bugs

Assignee:

Evan Martin <evan>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	tony: review+

Description Evan Martin 2011-04-28 15:25:23 PDT

[chromium] support components build on Linux

Comment 1 Evan Martin 2011-04-28 15:26:44 PDT

Created attachment 91567 [details]
Patch

Comment 2 Tony Chang 2011-04-28 15:30:13 PDT

Comment on attachment 91567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91567&action=review

> Source/WebKit/chromium/WebKit.gyp:641
> +                                ['OS=="win" or OS=="mac"', {

Why mac for this one?  Wasn't this in a win only block above?

Comment 3 Evan Martin 2011-04-29 14:40:55 PDT

Created attachment 91741 [details]
Patch

Comment 4 Evan Martin 2011-04-29 14:41:31 PDT

(In reply to comment #2)
> (From update of attachment 91567 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91567&action=review
> 
> > Source/WebKit/chromium/WebKit.gyp:641
> > +                                ['OS=="win" or OS=="mac"', {
> 
> Why mac for this one?  Wasn't this in a win only block above?

Components was win-only overall.  I believe this is correct for Mac, though I'm not sure.

Comment 5 Evan Martin 2011-04-29 14:43:19 PDT

Created attachment 91743 [details]
Patch

Comment 6 Tony Chang 2011-04-29 15:07:03 PDT

Comment on attachment 91743 [details]
Patch

OK!

Comment 7 Evan Martin 2011-04-29 15:20:15 PDT

Committed r85362: <http://trac.webkit.org/changeset/85362>