Bug 59740

Summary: DFG JIT - Unify GPRReg & RegisterID
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch oliver: review+

Gavin Barraclough
Reported 2011-04-28 14:35:49 PDT
Currently we use a mix of enum values throughout the DFG JIT to represent gpr registers - the RegisterID provided by the MacroAssembler, and the GPRReg enum giving the sequential register set over which the RegisterBank allocates. Unify the two.
Attachments
The patch (136.44 KB, patch)
2011-04-28 14:37 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-04-28 14:37:42 PDT
Created attachment 91559 [details] The patch Patch to unify FPRReg in a similar fashion will follow.
Oliver Hunt
Comment 2 2011-04-28 14:47:13 PDT
Comment on attachment 91559 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=91559&action=review Fix the x86 specific badness > Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.h:173 > + GPRReg canTrample = (preserve == X86Registers::eax) ? X86Registers::edx : X86Registers::eax; Ye cannae do that captain!!!!! > Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.h:187 > + GPRReg canTrample = (preserve == X86Registers::eax) ? X86Registers::edx : X86Registers::eax; Ach no!!
Gavin Barraclough
Comment 3 2011-04-28 15:32:24 PDT
resolved in 85249
Note You need to log in before you can comment on or make changes to this bug.