Bug 59695

Summary:

[GTK] Build webkit1 even when webkit2 is enabled

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	eric: review+

Carlos Garcia Campos

Reported 2011-04-28 06:26:52 PDT

Webkit1 and Webkit2 are currently built seprated, but they could be built at the same time using the same libWebCore.

Attachments
Patch (4.40 KB, patch) 2011-04-28 06:29 PDT, Carlos Garcia Campos	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2011-04-28 06:29:29 PDT

Created attachment 91479 [details] Patch Webkit2 is still disabled by default, but when enabled, webkit1 is built too.

Martin Robinson

Comment 2 2011-04-28 09:20:16 PDT

Comment on attachment 91479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91479&action=review > GNUmakefile.am:-235 > -stamp-po: Is it safe to remove this stamp-po rule?

Carlos Garcia Campos

Comment 3 2011-04-28 09:41:37 PDT

(In reply to comment #2) > (From update of attachment 91479 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91479&action=review > > > GNUmakefile.am:-235 > > -stamp-po: > > Is it safe to remove this stamp-po rule? It's actually defined in the webkit1 gtk makefile, we have to fix #55153. But it doesn't affect the build.

Eric Seidel (no email)

Comment 4 2011-05-01 10:51:17 PDT

Comment on attachment 91479 [details] Patch Martin seemed OK with the change otherwise. rs=me assuming you don't break the gtk build.

Carlos Garcia Campos

Comment 5 2011-05-03 02:53:49 PDT

Note You need to log in before you can comment on or make changes to this bug.