Bug 5969

Summary:

SVG is missing <mask> support

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-masking-mask-01-b.html

Bug Depends on:

6327, 6337

Bug Blocks:

Attachments:

Description	Flags
reduced testcase	none
reduced testcase (updated)	none
preliminary <mask> support	none
preliminary <mask> support patch	none
alpha mask test	none
cleaned up patch	none
fixing leaks and more style issues noticed by macdome	none
<mask> patch	none
layouttests patch	none
<mask> support, refactored	none
<mask> support, refactored, style changes	eric: review+
changelog addition	none

Description Eric Seidel (no email) 2005-12-06 03:54:20 PST

SVG is missing <mask> support

This would be very easy to do (very similar logic to <clippath>)  I just haven't gotten around to it yet.

Comment 1 Alexander Kellett 2005-12-10 18:19:23 PST

Created attachment 5024 [details]
reduced testcase

Comment 2 Alexander Kellett 2005-12-29 23:39:54 PST

Created attachment 5370 [details]
reduced testcase (updated)

moved rect outside defs to fix a possible bug in the current implementation

Comment 3 Alexander Kellett 2005-12-29 23:45:30 PST

Created attachment 5371 [details]
preliminary <mask> support

issues:
   see previously attached comment on testcase (possible bug - related to
<defs>)
   currently does not allow for usage of the alpha in the mask, thusly the
above testcase has been modified to use a black/white gradient instead
   the rgb to grayscale conversion is not per spec

the code to fix the above rgb/rgba related issues has been #ifdef'd out as its
not yet ready for final commit

Comment 4 Alexander Kellett 2005-12-30 00:19:46 PST

Created attachment 5372 [details]
preliminary <mask> support patch

several style changes following review from macdome

Comment 5 Alexander Kellett 2005-12-30 12:51:00 PST

Created attachment 5386 [details]
alpha mask test

Comment 6 Alexander Kellett 2005-12-30 16:15:09 PST

Created attachment 5389 [details]
cleaned up patch

Comment 7 Alexander Kellett 2005-12-30 18:13:42 PST

Created attachment 5391 [details]
fixing leaks and more style issues noticed by macdome

Comment 8 Alexander Kellett 2005-12-30 18:16:59 PST

Created attachment 5392 [details]
<mask> patch

Comment 9 Alexander Kellett 2006-01-03 10:41:11 PST

Created attachment 5453 [details]
layouttests patch

Comment 10 Alexander Kellett 2006-01-03 14:12:53 PST

Created attachment 5457 [details]
<mask> support, refactored

Comment 11 Alexander Kellett 2006-01-03 14:36:13 PST

Created attachment 5460 [details]
<mask> support, refactored, style changes

Comment 12 Alexander Kellett 2006-01-03 14:51:28 PST

Created attachment 5461 [details]
changelog addition

Comment 13 Eric Seidel (no email) 2006-01-03 22:32:57 PST

Comment on attachment 5460 [details]
<mask> support, refactored, style changes

Looks good!
r=me

Comment 14 Eric Seidel (no email) 2006-01-06 01:08:55 PST

Basic support landed.  We'll need another bug to cover missing features.