Bug 5969

Summary:

SVG is missing <mask> support

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-masking-mask-01-b.html

Bug Depends on:

6327, 6337

Bug Blocks:

Attachments:

Description	Flags
reduced testcase	none
reduced testcase (updated)	none
preliminary <mask> support	none
preliminary <mask> support patch	none
alpha mask test	none
cleaned up patch	none
fixing leaks and more style issues noticed by macdome	none
<mask> patch	none
layouttests patch	none
<mask> support, refactored	none
<mask> support, refactored, style changes	eric: review+
changelog addition	none

Eric Seidel (no email)

Reported 2005-12-06 03:54:20 PST

SVG is missing <mask> support This would be very easy to do (very similar logic to <clippath>) I just haven't gotten around to it yet.

Attachments
reduced testcase (996 bytes, image/svg+xml) 2005-12-10 18:19 PST, Alexander Kellett	no flags	Details
reduced testcase (updated) (1011 bytes, image/svg+xml) 2005-12-29 23:39 PST, Alexander Kellett	no flags	Details
preliminary <mask> support (31.72 KB, patch) 2005-12-29 23:45 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
preliminary <mask> support patch (32.01 KB, patch) 2005-12-30 00:19 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
alpha mask test (977 bytes, image/svg+xml) 2005-12-30 12:51 PST, Alexander Kellett	no flags	Details
cleaned up patch (30.84 KB, patch) 2005-12-30 16:15 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
fixing leaks and more style issues noticed by macdome (31.34 KB, patch) 2005-12-30 18:13 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
<mask> patch (31.32 KB, patch) 2005-12-30 18:16 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
layouttests patch (2.92 KB, patch) 2006-01-03 10:41 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
<mask> support, refactored (40.45 KB, patch) 2006-01-03 14:12 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
<mask> support, refactored, style changes (40.28 KB, patch) 2006-01-03 14:36 PST, Alexander Kellett	eric: review+	Details Formatted Diff Diff
changelog addition (1.61 KB, text/plain) 2006-01-03 14:51 PST, Alexander Kellett	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Alexander Kellett

Comment 1 2005-12-10 18:19:23 PST

Created attachment 5024 [details] reduced testcase

Alexander Kellett

Comment 2 2005-12-29 23:39:54 PST

Created attachment 5370 [details] reduced testcase (updated) moved rect outside defs to fix a possible bug in the current implementation

Alexander Kellett

Comment 3 2005-12-29 23:45:30 PST

Created attachment 5371 [details] preliminary <mask> support issues: see previously attached comment on testcase (possible bug - related to <defs>) currently does not allow for usage of the alpha in the mask, thusly the above testcase has been modified to use a black/white gradient instead the rgb to grayscale conversion is not per spec the code to fix the above rgb/rgba related issues has been #ifdef'd out as its not yet ready for final commit

Alexander Kellett

Comment 4 2005-12-30 00:19:46 PST

Created attachment 5372 [details] preliminary <mask> support patch several style changes following review from macdome

Alexander Kellett

Comment 5 2005-12-30 12:51:00 PST

Created attachment 5386 [details] alpha mask test

Alexander Kellett

Comment 6 2005-12-30 16:15:09 PST

Created attachment 5389 [details] cleaned up patch

Alexander Kellett

Comment 7 2005-12-30 18:13:42 PST

Created attachment 5391 [details] fixing leaks and more style issues noticed by macdome

Alexander Kellett

Comment 8 2005-12-30 18:16:59 PST

Created attachment 5392 [details] <mask> patch

Alexander Kellett

Comment 9 2006-01-03 10:41:11 PST

Created attachment 5453 [details] layouttests patch

Alexander Kellett

Comment 10 2006-01-03 14:12:53 PST

Created attachment 5457 [details] <mask> support, refactored

Alexander Kellett

Comment 11 2006-01-03 14:36:13 PST

Created attachment 5460 [details] <mask> support, refactored, style changes

Alexander Kellett

Comment 12 2006-01-03 14:51:28 PST

Created attachment 5461 [details] changelog addition

Eric Seidel (no email)

Comment 13 2006-01-03 22:32:57 PST

Comment on attachment 5460 [details] <mask> support, refactored, style changes Looks good! r=me

Eric Seidel (no email)

Comment 14 2006-01-06 01:08:55 PST

Basic support landed. We'll need another bug to cover missing features.

Note You need to log in before you can comment on or make changes to this bug.