Bug 5967

Summary:

Markers have slight clipping issues

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ian, julien.palmas

Priority:

Keywords:

HasReduction

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-painting-marker-02-f.html

Attachments:

Description	Flags
Test case	none
Actuall result	none
Expected result	none
Fix with test case.	adele: review+

Eric Seidel (no email)

Reported 2005-12-06 03:50:47 PST

Markers have slight clipping issues At least according to bartocc (Julien) who wrote our marker support. This can be easily seen by viewing this test case: http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-painting-marker-02-f.html

Attachments
Test case (552 bytes, image/svg+xml) 2005-12-11 09:49 PST, Julien Palmas	no flags	Details
Actuall result (2.77 KB, image/png) 2005-12-11 09:49 PST, Julien Palmas	no flags	Details
Expected result (2.18 KB, image/png) 2005-12-11 09:50 PST, Julien Palmas	no flags	Details
Fix with test case. (25.63 KB, patch) 2006-09-19 19:15 PDT, Eric Seidel (no email)	adele: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2005-12-08 01:56:15 PST

Julien, can you please add a fuller description to this bug as to what exactly is wrong. This bug came out of my recollection from IRC conversations you and I had about markers.

Julien Palmas

Comment 2 2005-12-11 09:49:33 PST

Created attachment 5037 [details] Test case

Julien Palmas

Comment 3 2005-12-11 09:49:54 PST

Created attachment 5038 [details] Actuall result

Julien Palmas

Comment 4 2005-12-11 09:50:14 PST

Created attachment 5039 [details] Expected result

Julien Palmas

Comment 5 2005-12-11 09:51:28 PST

Eric, this bug needs to be marked as "HasReduction"

Julien Palmas

Comment 6 2005-12-11 10:22:46 PST

This bug is likely a duplicate of http://bugzilla.opendarwin.org/show_bug.cgi?id=5358

Eric Seidel (no email)

Comment 7 2006-09-19 19:15:13 PDT

Created attachment 10660 [details] Fix with test case.

Eric Seidel (no email)

Comment 8 2006-09-19 22:12:58 PDT

I'll explain the fix a little better. Markers implicitly create a RenderSVGContainer to hold all their children for rendering. The bug was that markers were using their own custom viewport scaling hack instead of using the RenderSVGContainer viewport() setters. I changed markers to have full viewport support. Fixing that required refX and refY support to change a little though due to the order in which transforms are applied inside RenderSVGContainer. There is some cleanup in this patch, but the most exicting stuff is the logic change in KCanvasMaker::draw

Eric Seidel (no email)

Comment 9 2006-09-19 22:27:45 PDT

r16461

Note You need to log in before you can comment on or make changes to this bug.