Bug 59663

Summary:

check-webkit-style error for spaces after periods in a comment has a bad error message and warns about end of line spaces.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

New Bugs

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, hamaji

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

David Levin

Reported 2011-04-27 18:13:47 PDT

check-webkit-style error for spaces after periods in a comment has a bad error message and warns about end of line spaces.

Attachments
Patch (4.61 KB, patch) 2011-04-27 18:14 PDT, David Levin	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Levin

Comment 1 2011-04-27 18:14:59 PDT

Created attachment 91393 [details] Patch

Adam Barth

Comment 2 2011-04-27 18:38:42 PDT

Comment on attachment 91393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91393&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1761 > - 'Should only a single space after a punctuation in a comment.') > + 'Should only have a single space after a punctuation in a comment.') Should only have => Should have only

David Levin

Comment 3 2011-04-27 18:49:33 PDT

Committed as http://trac.webkit.org/changeset/85137.

Note You need to log in before you can comment on or make changes to this bug.