Bug 59647

Summary: fast/dom/shadow/gc-shadow.html should have failing results for Mac
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 59571    
Attachments:
Description Flags
Patch
none
Patch dglazkov: review+, commit-queue: commit-queue-

Dominic Cooney
Reported 2011-04-27 16:13:05 PDT
To verify the fix to bug 59571 fast/dom/shadow/gc-shadow.html should have a platform-specific result for Mac demonstrating the test failure.
Attachments
Patch (2.46 KB, patch)
2011-04-27 16:16 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Patch (5.58 KB, patch)
2011-04-27 18:25 PDT, Dominic Cooney 		dglazkov: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-04-27 16:16:06 PDT
Created attachment 91369 [details] Patch
Dominic Cooney
Comment 2 2011-04-27 18:25:36 PDT
Created attachment 91399 [details] Patch
Dominic Cooney
Comment 3 2011-04-27 18:26:29 PDT
Updated patch that takes the test approach suggested by ggaren in bug 59571.
Dimitri Glazkov (Google)
Comment 4 2011-04-28 09:34:43 PDT
Comment on attachment 91399 [details] Patch k
WebKit Commit Bot
Comment 5 2011-04-28 10:15:42 PDT
Comment on attachment 91399 [details] Patch Rejecting attachment 91399 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: with fuzz 3. patching file LayoutTests/fast/dom/shadow/gc-shadow-expected.txt patching file LayoutTests/fast/dom/shadow/gc-shadow.html patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 336. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patching file LayoutTests/platform/mac/fast/dom/shadow/gc-shadow-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8513816
Dimitri Glazkov (Google)
Comment 6 2011-04-28 10:52:31 PDT
Committed r85209: <http://trac.webkit.org/changeset/85209>
WebKit Review Bot
Comment 7 2011-04-28 11:25:02 PDT
http://trac.webkit.org/changeset/85209 might have broken SnowLeopard Intel Release (Tests)
Dimitri Glazkov (Google)
Comment 8 2011-04-28 11:40:55 PDT
(In reply to comment #7) > http://trac.webkit.org/changeset/85209 might have broken SnowLeopard Intel Release (Tests) DOH. Missed failing results. Landed in http://trac.webkit.org/changeset/85215.
Note You need to log in before you can comment on or make changes to this bug.