Summary: | fast/dom/shadow/gc-shadow.html should have failing results for Mac | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominic Cooney <dominicc> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, ggaren, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 59571 | ||||||||
Attachments: |
|
Description
Dominic Cooney
2011-04-27 16:13:05 PDT
Created attachment 91369 [details]
Patch
Created attachment 91399 [details]
Patch
Updated patch that takes the test approach suggested by ggaren in bug 59571. Comment on attachment 91399 [details]
Patch
k
Comment on attachment 91399 [details] Patch Rejecting attachment 91399 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: with fuzz 3. patching file LayoutTests/fast/dom/shadow/gc-shadow-expected.txt patching file LayoutTests/fast/dom/shadow/gc-shadow.html patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 336. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patching file LayoutTests/platform/mac/fast/dom/shadow/gc-shadow-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8513816 Committed r85209: <http://trac.webkit.org/changeset/85209> http://trac.webkit.org/changeset/85209 might have broken SnowLeopard Intel Release (Tests) (In reply to comment #7) > http://trac.webkit.org/changeset/85209 might have broken SnowLeopard Intel Release (Tests) DOH. Missed failing results. Landed in http://trac.webkit.org/changeset/85215. |