Bug 5964

Summary: Animation (<animateColor>, <animateTransform>, etc) are broken after DOM Merger
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Makes animation work again. darin: review+

Eric Seidel (no email)
Reported 2005-12-06 03:42:56 PST
Animation (<animateColor>, <animateTransform>, etc) are broken after DOM Merger I moved the KSVGTimeScheduler onto <svg> (which was wrong), and I'm also no longer using SVGDocumentImpl (and DocumentImpl doesnt' know how to kick off the timers, etc.) All these will have to be fixed to make animations work again.
Attachments
Makes animation work again. (25.57 KB, patch)
2006-01-21 22:57 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-01-21 22:57:34 PST
Created attachment 5826 [details] Makes animation work again. This patch makes <animateColor> work again. It stopped working because the timers were never started. During the DOM merger I moved much of the SVGDocumentImpl logic onto SVGSVGElementImpl in an effort not to modify DocumentImpl too much. Now I've created a SVGDocumentExtensions class to hold all of the SVGDocumentImpl specific goop. Eventually we'll create an HTMLDocumentExtensions class and that can hold all the HTML specific goop which is currently found in DocumentImpl.
Darin Adler
Comment 2 2006-01-22 10:28:47 PST
Comment on attachment 5826 [details] Makes animation work again. Looks good. r=me
Note You need to log in before you can comment on or make changes to this bug.