Bug 59631

Summary: Port Mozilla's IndexedDB tests: creating unique index and updating indexNames
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dgrogan, fishd, hans, pilgrim, tony
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Mark Pilgrim (Google) 2011-04-27 13:55:16 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_create_index.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It checks the basics of creating a unique index and seeing that indexNames is updated afterwards. WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-04-27 13:56:53 PDT
Created attachment 91340 [details]
Patch
Comment 2 David Grogan 2011-04-27 14:22:31 PDT
Comment on attachment 91340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91340&action=review

Good stuff.

> LayoutTests/storage/indexeddb/mozilla/create-index-unique.html:49
> +function cleanDatabase()

Same comment as yesterday - change to a less misleading name.  This does more than cleaning the database.
Comment 3 Mark Pilgrim (Google) 2011-04-27 14:37:42 PDT
Created attachment 91351 [details]
Patch
Comment 4 Mark Pilgrim (Google) 2011-04-27 14:38:24 PDT
Fixed function name. No other changes.
Comment 5 David Grogan 2011-04-27 14:39:40 PDT
Comment on attachment 91351 [details]
Patch

r+
Comment 6 WebKit Commit Bot 2011-04-27 22:20:05 PDT
Comment on attachment 91351 [details]
Patch

Clearing flags on attachment: 91351

Committed r85154: <http://trac.webkit.org/changeset/85154>
Comment 7 WebKit Commit Bot 2011-04-27 22:20:10 PDT
All reviewed patches have been landed.  Closing bug.