Bug 59628

Summary: Make start parameter of Blob.slice optional
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dimich, eric, fishd, kbr, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch kbr: review+, jianli: commit-queue-

Jian Li
Reported 2011-04-27 13:35:15 PDT
We need to make start parameter of Blob.slice optional, per the latest File API spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
Attachments
Proposed Patch (4.06 KB, patch)
2011-04-27 13:54 PDT, Jian Li 		kbr: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2011-04-27 13:54:00 PDT
Created attachment 91339 [details] Proposed Patch
Eric Seidel (no email)
Comment 2 2011-05-01 12:05:35 PDT
There was a gigantic thread about this on webkit-dev. I'm surprised more of those players aren't cc'd here.
Eric Seidel (no email)
Comment 3 2011-05-23 15:50:28 PDT
Jian: Could you please CC the relevant people and get this resolved? it's been in the queue for almost a month.
Jian Li
Comment 4 2011-05-23 16:04:29 PDT
Per the discussion, we decide to do no change to how code generator handles optional parameter since it is the right behavior as in ECMA-262. The spec author Arun also updated the File API spec to explicitly illustrate the case for optional end parameter. The only change in this patch to make start parameter as optional. It does not change any other existing behaviors. CC peoples that were in the discussion if they have more to day.
Kenneth Russell
Comment 5 2011-05-23 16:09:36 PDT
Comment on attachment 91339 [details] Proposed Patch Looks fine.
Jian Li
Comment 6 2011-05-24 11:58:39 PDT
Committed as https://trac.webkit.org/changeset/87181.
Note You need to log in before you can comment on or make changes to this bug.