Web Inspector: add ResourceTreeModel test for initial load.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 91302 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 91302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91302&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:167
> +        if (!resource.statusCode || resource.statusCode === 200 || resource.statusCode === 304)

Can we use something like hasContent instead of this check? Also, note that responses like 404 may contain custom html code explaining the error.

[Pavel Feldman]

Created attachment 91311 [details]
Patch

[Pavel Feldman]

Created attachment 91483 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 91483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91483&action=review

> LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:53
> +Tests resource tree model on iframe navigation.

Please describe what should be treated as a correct result, it's hard to guess it from the test output.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:90
> +            this._subframes[frame.parentId] = subframes;

Is it possible that the frame is the main frame?

[Pavel Feldman]

Committed r85184: <http://trac.webkit.org/changeset/85184>

[WebKit Review Bot]

http://trac.webkit.org/changeset/85184 might have broken Qt Linux Release
The following tests are not passing:
http/tests/inspector/resource-tree/resource-tree-frame-add.html
http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
http/tests/inspector/resource-tree/resource-tree-reload.html