Summary: | [GTK][Qt] fast/events/keydown-1.html fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Chang Shu <cshu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, cshu | ||||
Priority: | P3 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Martin Robinson
2011-04-27 00:57:22 PDT
FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though. (In reply to comment #1) > FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though. Yes, even before the text conversion this test was incredibly flaky across different machines. The text conversion provides good impetus to finally squash this bug. I believe so. The pixel result may falsely consider it's passing because one dot doesn't contribute much in the whole image. This test also fails on Qt but it was skipped. I suspect it's a key binding issue. Probably we should rewrite the test to use common key codes. Created attachment 91970 [details]
fix patch
Comment on attachment 91970 [details]
fix patch
Thanks!
The commit-queue encountered the following flaky tests while processing attachment 91970 [details]: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 91970 [details] fix patch Clearing flags on attachment: 91970 Committed r85528: <http://trac.webkit.org/changeset/85528> All reviewed patches have been landed. Closing bug. |