Bug 59558

Summary: REGRESSION(r84951): "breaks chromium compile" (Requested by dpranke on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov, dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 54969    
Attachments:
Description Flags
ROLLOUT of r84951 none

Description WebKit Review Bot 2011-04-26 16:45:04 PDT
http://trac.webkit.org/changeset/84951 broke the build:
"breaks chromium compile" (Requested by dpranke on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-04-26 16:45:23 PDT
Created attachment 91179 [details]
ROLLOUT of r84951

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Dirk Pranke 2011-04-26 16:53:12 PDT
Comment on attachment 91179 [details]
ROLLOUT of r84951

Clearing flags on attachment: 91179

Committed r84982: <http://trac.webkit.org/changeset/84982>
Comment 3 Dirk Pranke 2011-04-26 16:53:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Dirk Pranke 2011-04-26 19:00:35 PDT
Reverted r84982 for reason:

re-land r84951

Committed r85001: <http://trac.webkit.org/changeset/85001>
Comment 5 WebKit Review Bot 2011-04-26 21:17:51 PDT
http://trac.webkit.org/changeset/85001 might have broken SnowLeopard Intel Release (WebKit2 Tests)
Comment 6 Stephen Chenney 2013-04-09 16:10:46 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.