Bug 59493

Summary: Preserve-3d and transform with toggling box-reflect produces unexpected issues
Product: WebKit Reporter: Arne Bech <arne>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, ap, ariya.hidayat, arne, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase none

Arne Bech
Reported 2011-04-26 14:17:50 PDT
To reproduce: open attached test case (index.html). The test case has some js in it that toggles a css class (which contains a box reflect rule) on a div. The div is positioned with absolute positioning and have a translate3d transform applied. There is a catch all rule applying preserve-3d style to all elements. In Safari 5.0.5 it causes the div to wander across the screen seemingly in the direction of the translate3d transform. In the most recent webkit nightly this causes the browser to crash: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000018 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000101648bb9 WebCore::PlatformCALayer::replaceSublayer(WebCore::PlatformCALayer*, WebCore::PlatformCALayer*) + 9 1 com.apple.WebCore 0x00000001010148c4 WebCore::GraphicsLayerCA::ensureStructuralLayer(WebCore::GraphicsLayerCA::StructuralLayerPurpose) + 1236 2 com.apple.WebCore 0x0000000101014e15 WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers() + 981 3 com.apple.WebCore 0x0000000101014e45 WebCore::GraphicsLayerCA::recursiveCommitChanges() + 21 4 com.apple.WebCore 0x0000000101014e81 WebCore::GraphicsLayerCA::recursiveCommitChanges() + 81 5 com.apple.WebCore 0x0000000101014e81 WebCore::GraphicsLayerCA::recursiveCommitChanges() + 81 6 com.apple.WebCore 0x0000000101014e81 WebCore::GraphicsLayerCA::recursiveCommitChanges() + 81 7 com.apple.WebCore 0x0000000101014e81 WebCore::GraphicsLayerCA::recursiveCommitChanges() + 81 8 com.apple.WebCore 0x00000001016f0b69 WebCore::RenderLayerCompositor::flushPendingLayerChanges() + 41 9 com.apple.WebCore 0x0000000100fd9127 WebCore::FrameView::syncCompositingStateForThisFrame() + 167 10 com.apple.WebCore 0x0000000100fda185 WebCore::FrameView::syncCompositingStateIncludingSubframes() + 21 11 com.apple.WebKit 0x0000000100ad6b86 -[WebView(WebViewInternal) _syncCompositingChanges] + 38 12 com.apple.WebKit 0x0000000100ac877f layerSyncRunLoopObserverCallBack(__CFRunLoopObserver*, unsigned long, void*) + 79 13 com.apple.CoreFoundation 0x00007fff86ee7b37 __CFRunLoopDoObservers + 519 14 com.apple.CoreFoundation 0x00007fff86ec363f __CFRunLoopRun + 943 15 com.apple.CoreFoundation 0x00007fff86ec2dbf CFRunLoopRunSpecific + 575 16 com.apple.HIToolbox 0x00007fff812fc7ee RunCurrentEventLoopInMode + 333 17 com.apple.HIToolbox 0x00007fff812fc5f3 ReceiveNextEventCommon + 310 18 com.apple.HIToolbox 0x00007fff812fc4ac BlockUntilNextEventMatchingListInMode + 59 19 com.apple.AppKit 0x00007fff834abe64 _DPSNextEvent + 718 20 com.apple.AppKit 0x00007fff834ab7a9 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 155 21 com.apple.Safari 0x0000000100015ff6 0x100000000 + 90102 22 com.apple.AppKit 0x00007fff8347148b -[NSApplication run] + 395 23 com.apple.AppKit 0x00007fff8346a1a8 NSApplicationMain + 364 24 com.apple.Safari 0x0000000100009f18 0x100000000 + 40728
Attachments
Testcase (954 bytes, text/html)
2011-04-26 14:18 PDT, Arne Bech 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Arne Bech
Comment 1 2011-04-26 14:18:39 PDT
Created attachment 91157 [details] Testcase
Ahmad Saleem
Comment 2 2023-02-03 05:46:11 PST
Safari 16.3 does not crash on the attached test case and also WebKit ToT build running via run-safari --release. Do we need to track anything here? Thanks!
Alexey Proskuryakov
Comment 3 2023-02-03 08:41:01 PST
Crashes this old are indeed unlikely to still reproduce, but technically, this was a WebKit1 bug, and this functionality works very differently in WebKit2. So it needs to be tested in MiniBrowser using a legacy WebKit window.
Ahmad Saleem
Comment 4 2023-02-03 08:43:11 PST
(In reply to Alexey Proskuryakov from comment #3) > Crashes this old are indeed unlikely to still reproduce, but technically, > this was a WebKit1 bug, and this functionality works very differently in > WebKit2. So it needs to be tested in MiniBrowser using a legacy WebKit > window. It does not crash in mini-browser WebKit1 window as well based on WebKit Trunk of 259744@main.
Alexey Proskuryakov
Comment 5 2023-02-03 08:44:54 PST
Yay!
Note You need to log in before you can comment on or make changes to this bug.