Summary: | [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||||||
Component: | WebKit2 | Assignee: | Siddharth Mathur <s.mathur> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, kbalazs, kenneth, laszlo.gombos | ||||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | S60 Hardware | ||||||||||
OS: | S60 3rd edition | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 50251 | ||||||||||
Attachments: |
|
Description
Siddharth Mathur
2011-04-26 08:20:06 PDT
Created attachment 91110 [details]
Patch
Comment on attachment 91110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91110&action=review > Source/WebKit2/ChangeLog:5 > + [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian + Minor UI changes The two changesets are completely unrelated and should be split up into separate patches. > Tools/MiniBrowser/qt/MiniBrowser.pro:59 > + # http://doc.qt.nokia.com/qtmobility/quickstart.html Out of curiosity, is there no way to express that you're using QtMobility and therefore require the capabilities used by that library? Created attachment 92240 [details]
Patch
Comment on attachment 92240 [details]
Patch
Hmm, webkit-patch user error. sorry.
Created attachment 92243 [details]
Updated patch with for Symbian executable properties only
Comment on attachment 92243 [details]
Updated patch with for Symbian executable properties only
lgtm, r+.
Comment on attachment 92243 [details] Updated patch with for Symbian executable properties only Clearing flags on attachment: 92243 Committed r85803: <http://trac.webkit.org/changeset/85803> All reviewed patches have been landed. Closing bug. |