Bug 59411 – [EFL] Change cursor to LAZY_NATIVE_CURSOR

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

Other ports use LAZY_NATIVE_CURSOR, but EFL doesn't.

[Ryuan Choi]

Created attachment 91046 [details]
Patch

[Ryuan Choi]

Created attachment 91051 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 91051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91051&action=review

Looks fine except for the , strangeness.  I think we only do the leading comma for initializer lists.

> Source/WebCore/platform/efl/CursorEfl.cpp:62
> +        "cursor/pointer"
> +        , "cursor/cross"

I think we would normally write this "foo", and put a comma after every line.  But I'm not sure.

> Source/WebCore/platform/efl/CursorEfl.cpp:104
> +        , ""};

What's this for?

[Ryuan Choi]

Created attachment 91411 [details]
Patch

[Antonio Gomes]

Comment on attachment 91411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91411&action=review

> Source/WebCore/platform/efl/CursorEfl.cpp:58
> +static const char* getCursorString(Cursor::Type type)

We usually do not use "get" for getters.

> Source/WebCore/platform/efl/WidgetEfl.cpp:266
> +    const char *group = cursor.platformCursor();

* in the left side.

[Ryuan Choi]

(In reply to comment #3)
> (From update of attachment 91051 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91051&action=review
> 
> Looks fine except for the , strangeness.  I think we only do the leading comma for initializer lists.
> 
> > Source/WebCore/platform/efl/CursorEfl.cpp:62
> > +        "cursor/pointer"
> > +        , "cursor/cross"
> 
Thank you. It's my mistake and changed.

> I think we would normally write this "foo", and put a comma after every line.  But I'm not sure.
> 
> > Source/WebCore/platform/efl/CursorEfl.cpp:104
> > +        , ""};
> 
> What's this for?

WebCore::Cursor::Type have Custom, but EFL port doesn't support it yet.
"" at position of Custom will prevent exception.

[Ryuan Choi]

Created attachment 91413 [details]
Patch

[Ryuan Choi]

(In reply to comment #5)
> (From update of attachment 91411 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91411&action=review
> 
> > Source/WebCore/platform/efl/CursorEfl.cpp:58
> > +static const char* getCursorString(Cursor::Type type)
> 
changed to cursorString.

> We usually do not use "get" for getters.
> 
> > Source/WebCore/platform/efl/WidgetEfl.cpp:266
> > +    const char *group = cursor.platformCursor();
> 
> * in the left side.

Done.

Thank you for quick review.

[Antonio Gomes]

Comment on attachment 91413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91413&action=review

> Source/WebCore/platform/efl/CursorEfl.cpp:104
> +        ""};

>WebCore::Cursor::Type have Custom, but EFL port doesn't support it yet.
>"" at position of Custom will prevent exception.

add a comment?

[Ryuan Choi]

Created attachment 91422 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 91422 [details]
Patch

Clearing flags on attachment: 91422

Committed r85168: <http://trac.webkit.org/changeset/85168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.