Summary: | DFG JIT - add type speculation for integer & array types, for vars & args. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Barraclough
2011-04-25 17:20:25 PDT
Created attachment 91030 [details]
The patch
Attachment 91030 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:931: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.cpp:177: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/dfg/DFGGraph.h:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 91030 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=91030&action=review r=me > Source/JavaScriptCore/dfg/DFGGraph.h:141 > + if (operand < 0) { Probably worth a helper function to abstract away the fact that a negative number means an argument. > Source/JavaScriptCore/dfg/DFGGraph.h:151 > + if (operand < 0) { Ditto. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:290 > + // integerResult, but don't useChildren! Not new to this patch, but it would be good to explain the why here (phi nodes), instead of the what. |