Bug 59395

Summary: Fix OwnPtr strict errors in some SVG classes.
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jamesr, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch jamesr: review+

Description Adam Klein 2011-04-25 16:36:47 PDT 
Fix OwnPtr strict errors in some SVG classes.
Comment 1 Adam Klein 2011-04-25 16:37:29 PDT 
Created attachment 91013 [details]
Patch
Comment 2 James Robinson 2011-04-25 16:39:25 PDT 
Comment on attachment 91013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91013&action=review

so close!

> Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp:166
> +    , shadow(other.shadow ? adoptPtr(new ShadowData(*other.shadow)) : PassOwnPtr<ShadowData>(0))

PassOwnPtr<ShadowData>(), no '0'

> Source/WebCore/svg/SVGStyledTransformableElement.cpp:68
> +        m_supplementalTransform = adoptPtr(new AffineTransform());

nit: don't need the ()s on this c'tor

> Source/WebCore/svg/SVGTextElement.cpp:100
> +        m_supplementalTransform = adoptPtr(new AffineTransform());

nit: don't need the ()s on this c'tor
Comment 3 Adam Klein 2011-04-25 16:45:06 PDT 
Created attachment 91016 [details]
Patch
Comment 4 James Robinson 2011-04-25 16:48:24 PDT 
Comment on attachment 91016 [details]
Patch

Yay!
Comment 5 Adam Klein 2011-04-25 16:51:47 PDT 
Committed r84844: <http://trac.webkit.org/changeset/84844>
Comment 6 Adam Klein 2011-04-25 16:55:57 PDT 
Reverted r84844 for reason:

Checked

Committed r84847: <http://trac.webkit.org/changeset/84847>
Comment 7 Adam Klein 2011-04-25 17:00:00 PDT 
Created attachment 91026 [details]
Patch
Comment 8 James Robinson 2011-04-25 17:04:08 PDT 
Comment on attachment 91026 [details]
Patch

Still looks good
Comment 9 Adam Klein 2011-04-25 17:06:36 PDT 
Committed r84851: <http://trac.webkit.org/changeset/84851>