Bug 59378 – WebKit2: Should be able to inspect Web Inspector in Debug Builds

• Component: WebKit2
• Status: RESOLVED FIXED

[Brian Weinstein]

WebKit2: Should be able to inspect Web Inspector in Debug Builds

[Brian Weinstein]

Created attachment 90984 [details]
[PATCH] Fix

[Adam Roben (:aroben)]

Comment on attachment 90984 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=90984&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:62
>  WebPageGroup* WebInspectorProxy::inspectorPageGroup()
>  {
> -    static WebPageGroup* pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef();
> +    static WebPageGroup* pageGroup;
> +    if (pageGroup)
> +        return pageGroup;
> +
> +    pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef();
> +
> +#ifndef NDEBUG
> +    // Allow developers to inspect the Web Inspector in debug builds.
> +    pageGroup->preferences()->setDeveloperExtrasEnabled(true);
> +#endif
> +
>      return pageGroup;
>  }

I think it would be clearer to add a separate createInspectorPageGroup() helper function that had all the creation code. Then this function could stay simple.

[Brian Weinstein]

Created attachment 91011 [details]
[PATCH] Fix v2

[Adam Roben (:aroben)]

Comment on attachment 91011 [details]
[PATCH] Fix v2

View in context: https://bugs.webkit.org/attachment.cgi?id=91011&action=review

> Source/WebKit2/ChangeLog:9
> +        (WebKit::WebInspectorProxy::createInspectorPageGroup): Creates an inspector page group and enables

The "WebInspectorProxy::" part of this line is incorrect.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:50
> +static WebPageGroup* createInspectorPageGroup()
> +{
> +    WebPageGroup* pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef();

You should make this function return a PassRefPtr and put the leakRef at the call site.

[Brian Weinstein]

Landed in r84841.